Skip to content

Conversation

@bpintea
Copy link
Collaborator

@bpintea bpintea commented Feb 8, 2019

"Direct" registry access API was used to read the system info (DSN) on
connection establishment, if received connection string was not
sufficient.
This has now been replaced with existing code that uses ODBC Installer
API instead.

Close #107.

"Direct" registry access API was used to read the system info (DSN) on
connection establishment, if received connection string was not
sufficient.
This has now been replaced with existing code that uses ODBC installer
API instead.
Copy link
Collaborator

@edsavage edsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpintea bpintea merged commit 6ff9db9 into elastic:master Feb 11, 2019
@bpintea bpintea deleted the enh/odbcinst_for_system_info branch February 11, 2019 10:53
bpintea added a commit that referenced this pull request Feb 11, 2019
"Direct" registry access API was used to read the system info (DSN) on
connection establishment, if received connection string was not
sufficient.
This has now been replaced with existing code that uses ODBC installer
API instead.

(cherry picked from commit 6ff9db9)
@bpintea bpintea mentioned this pull request Feb 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants